Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities for management_ip modifications #1205

Merged
merged 1 commit into from
Nov 26, 2014
Merged

Conversation

zefciu
Copy link

@zefciu zefciu commented Nov 24, 2014

The Device object has now management_ip property to easily modificate its managament ip
Also a field was introduced to edit both hostname and IP.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 630116a on zefciu:RAS-71 into 3d47a8b on allegro:develop.

@xor-xor
Copy link
Contributor

xor-xor commented Nov 24, 2014

LGTM

@@ -36,6 +37,7 @@
from ralph.cmdb import models_ci
from ralph.discovery.models_component import is_mac_valid, Ethernet
from ralph.discovery.models_util import LastSeen, SavingUser
from ralph.discovery.models_network import IPAddress

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetic





Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 blank lines?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 456d24a on zefciu:RAS-71 into 97af7dd on allegro:develop.

The management_ip is a backwards-compatible property that allows to read
both legacy and new management IPs and save in the new way
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 2d04113 on zefciu:RAS-71 into 414efa0 on allegro:develop.

@kula1922
Copy link

lgtm

xor-xor added a commit that referenced this pull request Nov 26, 2014
Utilities for management_ip modifications
@xor-xor xor-xor merged commit 245db32 into allegro:develop Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants