Cloud images - support duplicated names #3467
Conversation
src/ralph/virtual/admin.py
Outdated
| @@ -514,7 +514,7 @@ class CloudProviderAdmin(RalphAdmin): | |||
| @register(CloudImage) | |||
| class CloudImageAdmin(RalphAdmin): | |||
| list_display = ['name', 'image_id'] | |||
| list_filter = ['name', 'image_id'] | |||
| list_filter = ['image_id'] | |||
There was a problem hiding this comment.
After giving it a thought I think it's actually better to leave the name here and get rid of the uuid -- I can imagine someone recalling a part of the image name and trying to filter by that, however, remembering an image uuid is unlikely.
There was a problem hiding this comment.
Another point is that it would be useful to enable API filtering by both name and uuid fields. API filters are defined on view sets and by default are copied from admin. So in this case it's necessary to add a list_filter property to CloudImageViewSet. Here you can find an example: https://github.com/allegro/ralph/blob/ng/src/ralph/virtual/api.py#L181
| @@ -16,13 +16,9 @@ class Migration(migrations.Migration): | |||
| name='CloudImage', | |||
There was a problem hiding this comment.
You cannot change already merged migrations -- they are already applied somewhere. Just generate a new one.
tomez
force-pushed
the
feature/cloud-images-duplicate-names
branch
2 times, most recently
from
1c0a169
to
a681457
Compare
tomez
force-pushed
the
feature/cloud-images-duplicate-names
branch
from
a681457
to
faf0b80
Compare
No description provided.