Ralph's views permissions review and fixes. #980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ralph_permission' decorator on 'dispatch' metod) and which should be present in mro path of every class-based view. Fixed 'ralph_permission' decorator and added 'decorated_with' property to it (for faciliating unit tests). Applied 'ralph_permission' decorator to the function-based views. Added test checking if every view inherits from 'ACLGateway' class (for class-based views) or is decorated with 'ralph_permission' decorator (for function-based views) - both of them are for enforcing permissions checks. This test includes a list of excluded callbacks and callbacks decorated manually (i.e. not inheriting from 'ACLGateway' class) - for the explaination see the comments in the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ACLGatewayclass which enforces permissions checks (viaralph_permissiondecorator ondispatchmetod) and which should be present inmropath of every class-based view.Fixed
ralph_permissiondecorator and addeddecorated_withproperty to it (for faciliating unit tests).Applied
ralph_permissiondecorator to the function-based views.Added test checking if every view inherits from
ACLGatewayclass (for class-based views) or is decorated withralph_permissiondecorator (for function-based views). This test includes a list of excluded callbacks and callbacks decorated manually (i.e. not inheriting fromACLGatewayclass) - for the explaination see the comments in the source code.