Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service & environment fields #988

Closed
wants to merge 6 commits into from
Closed

service & environment fields #988

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2014

Added dictlike field AssetEnvType to models.
Use it in ralph.discovery.device.

@quamilek @xorxor @ar4s

@@ -267,6 +273,20 @@ def get_uptime_display(self):
return "%s, %02d:%02d:%02d" % (msg, hours, minutes, seconds)


# TODO:: working-name, perhaps it should be changed
class AssetEnvType(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enviroment or DeviceEnviroment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 73b2eeb on xliiv:ser-env-fields into d0323cd on allegro:develop.

from ralph.business.admin import RolePropertyValueInline
from ralph.discovery import models as m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use explicit import.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling deb430d on xliiv:ser-env-fields into d0323cd on allegro:develop.

@ghost ghost changed the title [REVIEW ONLY] service & environment fields service & environment fields Jul 23, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 51ad688 on xliiv:ser-env-fields into d0323cd on allegro:develop.

@quamilek
Copy link
Member

👍

@ar4s
Copy link
Contributor

ar4s commented Jul 23, 2014

🆗

@ghost ghost closed this Jul 23, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants