This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
added DirectoryTimedRotatingFileHandler, removed sentry workaround, impr... #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mproved default loggers and config
| @@ -32,7 +32,7 @@ def update_assets_parts(data, date): | |||
|
|
|||
|
|
|||
| @plugin.register(chain='pricing', requires=['assets']) | |||
| def parts(**kwargs): | |||
| def assets_parts(**kwargs): | |||
| """Updates the devices from Ralph Assets.""" | |||
| date = kwargs['today'] | |||
| count = sum(update_assets_parts(data, date) for data in get_asset_parts()) | |||
There was a problem hiding this comment.
We can turn off this plugin at now. Exactly its not work correctly, saved device part don't have parent and some mistakes like this. What do you think? maybe just remove this plugin. It is only 40 lines of code contains imports and blank lines.
|
LGTM |
kula1922
added a commit
that referenced
this pull request
Jul 8, 2014
added DirectoryTimedRotatingFileHandler, removed sentry workaround, impr...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added DirectoryTimedRotatingFileHandler, removed sentry workaround, improved default loggers and config