fix for torch 2.1 inits #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Note that this does mean the model will be initialized twice for earlier versions, leading to slightly different inits for the same seed than we had before.
This isn't true given that we have the version check, right?
But for later versions, some params might be initialized twice, right? If so, is there a way to avoid that? Like force FSDP to materialize params but not apply init fn.
epwalsh
reviewed
Sep 26, 2023
epwalsh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In torch 2.1 FSDP now only calls reset_parameters() on modules which directly manage parameters (i.e. not the top level Olmo module).
Very simple fix: call olmo_model.reset_parameters() after the FSDP wrap. this recovers the loss curve from torch 2.0.1
No changes if using torch version < 2.1.0