mitchish LUMI run on its own branch #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
commented
Jan 5, 2024
| @@ -684,7 +684,7 @@ def _make_optim_state_dict_compatible( | |||
| # This state dict comes in two forms: one where the state keys are integers and one where the | |||
| # keys are fully qualified parameter names. The latter case is easier to deal with here so we | |||
| # first transform the integer key form into the FQN key form. | |||
| if isinstance(next(iter(optim_state_dict["state"].keys())), int): | |||
| if isinstance(optim_state_dict["param_groups"][0]["params"][0], int): | |||
There was a problem hiding this comment.
I had to make these fixes after trying to load an unsharded checkpoint with an uninitialized optimizer.
dirkgr
reviewed
Jan 5, 2024
Comment on lines
+67
to
+68
| --save_interval=10000 \ | ||
| --save_interval_ephemeral=1000 \ |
There was a problem hiding this comment.
That's a really low save interval? Total number of steps is only like 400k, right?
There was a problem hiding this comment.
I made this change to save disk space on LUMI. So we still save every 1k steps, and those get uploaded to S3, but since they are "ephemeral" (locally) they get cleaned up from LUMI.
2015aroras
reviewed
Jan 8, 2024
Comment on lines
+55
to
+56
| grad_clip_warmup_steps: 1000 | ||
| grad_clip_warmup_factor: 10.0 |
There was a problem hiding this comment.
Should this also be in the s3 yaml?
dirkgr
approved these changes
Jan 9, 2024
2015aroras
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #350.
To restart the run on LUMI:
git checkout mitchish-lumi git pull sbatch scripts/lumi/mitch-ish-7b.sh --load_path=$FLASH_DIR/checkpoints/{LAST_RUN_ID}/latest