-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage Cleaner] Add more basic functionality to storage adapters #380
Conversation
1a4e300
to
9c6cd51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One nit: A lot of the methods take some sort of path argument as a str
, and then convert to a Path
, while others take PathOrStr
. I think it would be cleaner to allow everything to take PathOrStr
.
The reason I use Most of the methods that take some a |
@epwalsh Sorry, didn't mean to re-request review for this one since it is more or less unchanged (just a different base). |
This adds or updates the following functionality for storage adapters:
is_dir
: Create a separate inner method to avoid calls between public-facing methods when the unsharder is implemented.download_folder
: Download a folder from storage to a local destination. Downloading a file can be done using cached path and so I exclude it.upload
: Upload a file or folder from local FS to storage.PR Train: