Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving memmap type parser #663

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Improving memmap type parser #663

merged 4 commits into from
Jul 17, 2024

Conversation

soldni
Copy link
Member

@soldni soldni commented Jul 17, 2024 •
edited
Loading

The old effective_memmap_dtype property will default to uint16 in case the dtype provided is not valid. This is bad because, as @drschwenk found, value numpy.uint32 will cause uint16 to be used.

New property will raise an TypeError if dtype is not recognized.

@soldni soldni requested a review from drschwenk July 17, 2024 06:08
drschwenk
drschwenk approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@drschwenk drschwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dirkgr
dirkgr approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's broader than I'd have done it, but that's OK. Not a big fan of silent errors. Massive fan of quick fixes.

@soldni soldni merged commit ab63296 into main Jul 17, 2024
12 checks passed
@soldni soldni deleted the soldni/dtype branch July 17, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkgr dirkgr dirkgr approved these changes

@drschwenk drschwenk drschwenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soldni @dirkgr @drschwenk