Fix typos #32
Merged
Fix typos #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcCote
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks a lot. LGTM. @PeterAJansen I'll let check it out before merging.
|
Looks good, most of these typos are in the code comments. There is also a change to the JAR file version. Can you verify this is accurate @MarcCote ? |
|
@PeterAJansen, the JAR file version was changed in ce05307. That commit missed changing the build script, so I fixed it here. |
|
Yes, I have the same change in my local version. We can merge.
…-Marc-
On Thu., Nov. 3, 2022, 16:49 Alex Hedges, ***@***.***> wrote:
@PeterAJansen <https://github.com/PeterAJansen>, the JAR file version was
changed in ce05307
<ce05307>.
That commit missed changing the build script, so I fixed it here.
—
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFBEJGRL6GXMTP43ZHWEGLWGQQOBANCNFSM6AAAAAARVLS2QI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #28, I have fixed some more typos in the codebase.
I also updated the JAR version in
package.shso it would build properly.