Fixing callbacks PR comments and other misc improvements. #350

Lucaweihs · 2022-07-29T18:38:05Z

PR:

Fixes the PR comments corresponding to PR Add Callback Support #339. In particular, callbacks that want data from tasks need to return a list of sensors that will be called on the task.
Introduces a number of other small misc improvement (a new CPCA loss ViT preprocessor, and better error handling).

…d error handling.

…llbacks init).

… to preprocessor.

…into callbacks-cpca-softmax

…k doesn't need to know anything about callbacks.

jordis-ai2

It looks good to me. I especially appreciate the effort in self-documenting the callbacks. Great job!

allenact/algorithms/onpolicy_sync/vector_sampled_tasks.py

allenact/base_abstractions/callbacks.py

jordis-ai2 · 2022-07-29T20:58:12Z

allenact/embodiedai/aux_losses/losses.py

+######## CPCA Softmax variants ######
+
+
+class CPCA1SoftMaxLoss(CPCASoftMaxLoss):


It's a bit tedious to have so many similar classes just because of the UUID. Would it be possible to have the uuid be an argument to __init__ and have some sort of factory that gives us the right instance given the needed uuid? Didn't think thoroughly about the cons of such a design, so feel free to ignore if it's completely out of scope.

Interesting! I could even imagine that the uuid could be something like "CPCASoftMaxLoss(planning_steps=8)" and then we could do some reflection to instantiate the class. For now I'll merge but will keep this in mind for the future.

Lucaweihs and others added 13 commits May 20, 2022 15:27

Look constraints, vit, and auxiliary losses.

79b7bbb

Fixing bug that resulted in cpca loss not running when it should.

41a7d2c

Merge branch 'main' of github.com:allenai/allenact into cpca-softmax

85a81c8

Merge branch 'cpca-softmax' into callbacks-cpca-softmax

7badab7

Improvements to manipulathor plugin, thor sensors, inference code, an…

90fe75c

…d error handling.

Improvements to error reporting and vector sampled task termination.

dea48a9

Extended timeout for TCP store access

d85853f

Removing argument parser input to the runner (previously passed to ca…

085739a

…llbacks init).

Generalizing clip preprocessor to use varying input sizes.

1fe09a4

Updating mixin to check for input image heights/widths before passing…

9016229

… to preprocessor.

Force advance scene for habitat objectnav.

2b538f5

Merge branch 'callbacks-cpca-softmax' of github.com:allenai/allenact …

60f2d8f

…into callbacks-cpca-softmax

Fixing callbacks pr requests, in particular making it so that a tas…

72e4fa4

…k doesn't need to know anything about callbacks.

Lucaweihs requested a review from mattdeitke July 29, 2022 18:38

Typo.

bd87a6f

Lucaweihs requested a review from jordis-ai2 July 29, 2022 19:59

jordis-ai2 approved these changes Jul 29, 2022

View reviewed changes

Lucaweihs added 3 commits August 2, 2022 13:27

Grabbing debug flag from the environment.

3e51c45

Improving grab of debug flag.

4812860

Using str2bool function.

d05d140

jordis-ai2 approved these changes Aug 3, 2022

View reviewed changes

Fix to ai2thor version check.

1cc558c

Lucaweihs merged commit e89eae1 into callbacks Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing callbacks PR comments and other misc improvements. #350

Fixing callbacks PR comments and other misc improvements. #350

Lucaweihs commented Jul 29, 2022

jordis-ai2 left a comment

jordis-ai2 Jul 29, 2022

Lucaweihs Aug 16, 2022

		######## CPCA Softmax variants ######


		class CPCA1SoftMaxLoss(CPCASoftMaxLoss):

Fixing callbacks PR comments and other misc improvements. #350

Fixing callbacks PR comments and other misc improvements. #350

Conversation

Lucaweihs commented Jul 29, 2022

jordis-ai2 left a comment

Choose a reason for hiding this comment

jordis-ai2 Jul 29, 2022

Choose a reason for hiding this comment

Lucaweihs Aug 16, 2022

Choose a reason for hiding this comment