Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug injecting nested lists. #220

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Fix bug injecting nested lists. #220

merged 1 commit into from
Feb 2, 2017

Conversation

jkinkead
Copy link
Contributor

@jkinkead jkinkead commented Feb 2, 2017

Here's the root cause of the S2 bug.

I hate unit-tested, vetted code that still has bugs.

@jkinkead jkinkead requested a review from vimsick February 2, 2017 22:11
vimsick
vimsick approved these changes Feb 2, 2017
View reviewed changes
Copy link

@vimsick vimsick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I'm a little concerned there is something that relies on the old behavior.

Thanks!

@jkinkead
Copy link
Contributor Author

jkinkead commented Feb 2, 2017

Since this should mostly fail to bind anything, it should be pretty dang obvious. I also don't think anyone who's using this (common-guice) has updated since I introduced this bug.

@jkinkead jkinkead merged commit c1fedd7 into allenai:master Feb 2, 2017
@jkinkead jkinkead deleted the fix_guice branch February 2, 2017 22:34
@vimsick
Copy link

vimsick commented Feb 2, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimsick vimsick vimsick approved these changes

Assignees

@vimsick vimsick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkinkead @vimsick