-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip sbt-plugins, deprecated / EOL frameworks + modules and cross-compile 2.11/2.12 #225
Conversation
* Removes webapp and indexing modules coupled to EOL spray framework * Moves settings from shared sbt-plugin (as few as possible) * Adds cross-version building!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It's a big PR but it's easy as it's mostly deletions--the best type of PR. LMK how else I can help.
@@ -1,68 +1,74 @@ | |||
import Dependencies._ | |||
|
|||
lazy val scala211 = "2.11.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you make these lazy val
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly just following the conventions in the SBT documentation. Probably not strictly necessary here because they are used immediately after, however, an example of an unused val is the scala213 val (for now).
<developer> | ||
<id>allenai-dev-role</id> | ||
<name>Allen Institute for Artificial Intelligence</name> | ||
<email>dev-role@allenai.org</email> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to check whether this address goes anywhere. @dplessas would know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will find out, thanks.
So much cleaning up!
Things I'm not sure about, that we should check before removing the dependency on the plugins:
If we have CI that checks formatting and a release process at least documented in a |
I think we did releases with a bintray plugin. I saw that @rreas left in a BinTray plugin--so we might be OK. Docs for releasing using BinTray: https://github.com/allenai/common#releasing-new-versions |
For release, I'm going to slightly update the process to have the actual release be less automated through CI since we release so rarely. I will also remove "Boss: Michael" from the Readme unless there are any objections @schmmd 😄 in addition to a few other tweaks. |
@rreas no objections ;-) At some point several years ago someone thought we should have a primary POC on repos and they wanted to call it the "boss". It was pretty short lived ;-) |
@rodneykinney Can you re-review? I am using a slightly newer formatter (Scalafmt) in this repository that provides the fail-on-would-reformat functionality out of the box and seems in general to be a bit more active than scalariform. The CI check is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot. I like the fact that we're trying out CircleCI. If we like it, we can use it for other S2 CI checks, and free up some resources on s2build
.
Pretty aggressive change set here that tries to balance doing the minimal to compile on 2.12. Here I am trying to reduce this "common" code to actual "common" code that is or can be used in nearly all projects with low dependency coupling. All to be released under 2.0.0+ versioning.
Summary of changes are:
Next steps: