Adding partition logic #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soldni
requested changes
May 21, 2024
There was a problem hiding this comment.
@Whattabatt left a few comments on supporting partitioning on all types of filtering (by document, by ngram). I think we could maybe move the check into the bloom filter itself?
| num_processed += 1; | ||
| //Compute the remaining hashes | ||
| hashes.extend(bloom_filter.remaining_hashes(&dedupe_key)); | ||
| if bloom_filter.contains(&hashes) { |
There was a problem hiding this comment.
uhm I don't fully follow the logic here. What I would do is have this contains function check if whatever you are putting into the bloom filter matches partition, and if so, put that into the filter.
There was a problem hiding this comment.
This is optimizing for reducing the number of hash function calls - partitioning only on the first hash of N and not doing any other hashing etc if it doesn't. Does that seem worthwhile? Regardless I'll add a comment since the behavior isn't super clear
soldni
requested changes
May 29, 2024
soldni
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.