Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share common code between event store and todo store #284

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Feb 3, 2024

Extract timezone, lookup, and update preparation code into a shared helper. This uses dtstart for determining timezone information rather than due date. Going forward, we'll ensure that todos have a dtstart.

#279

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d7f1ca1) 97.01% compared to head (7915fea) 97.03%.

Files Patch % Lines
ical/store.py 98.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   97.01%   97.03%   +0.02%     
==========================================
  Files          48       48              
  Lines        2915     2904      -11     
==========================================
- Hits         2828     2818      -10     
+ Misses         87       86       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit 83943db into main Feb 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant