adding a filter to manipulate page level targeting as a string #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another filter to this pull request in order to remove ad units that were slotted to the ad layer but that we know are not going to be displayed on the page (ie in-article ads that vary depending on article length). |
|
|
||
| if ( empty( $custom_targeting ) ) { | ||
| return; | ||
| } | ||
|
|
||
| $targeting_values = $this->get_targeting_js_from_array( $custom_targeting ); | ||
| $targeting_values = apply_filters( 'ad_layers_dfp_page_level_targeting_as_string', $this->get_targeting_js_from_array( $custom_targeting ) ); |
There was a problem hiding this comment.
Please rename this to ad_layers_dfp_page_level_targeting_output_html per recent direction from WordPress VIP.
|
Also this needs the merge conflict resolved. Thanks. |
Conflicts: php/ad-servers/class-ad-layers-dfp.php
|
I'm going to close this pull request. The changes requested are a month old at this point, and it seems like the changes requested no longer apply to how |
mboynes
added a commit
that referenced
this pull request
Oct 19, 2015
Re-implementing pull request #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created another filter to manipulate the page level targeting as a string. Spoke about this with @mboynes over slack last week. Wasn't sure about naming conventions for the filters, so any suggestions are welcome.