Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Spanish language #25

Merged
merged 7 commits into from
Apr 23, 2020
Merged

Implement Spanish language #25

merged 7 commits into from
Apr 23, 2020

Conversation

pablorodriper
Copy link
Contributor

Hi,

I've implemented Spanish language support for your module.

It works from 0 to 999 999 999 999 like the other languages, but ord2card() is not implemented.

Hope it helps.

Copy link
Collaborator

@rtxm rtxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!
I don't know Spanish, can you explain what is the difficulty with ordinals?

README.rst Outdated Show resolved Hide resolved
@pablorodriper
Copy link
Contributor Author

Thank you very much for your contribution!
I don't know Spanish, can you explain what is the difficulty with ordinals?

It's not very complicated, but we haven't got a unique suffix so it is like writing the cardinal number with other words. You can understand all the possibilities with the next picture:
https://es-static.z-dn.net/files/d82/d4d8c3ae63d4f2313b45fc5f13868ea7.png

@rtxm
Copy link
Collaborator

rtxm commented Apr 21, 2020

I see, better let them in full letters then!

@@ -74,6 +74,8 @@ def alpha2digit(
if you prefer to get « moins 2 » instead of « -2 ».
"""
language = LANG[lang]
if lang is "es":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is raises a warning with literals; you should use == here.

@rtxm
Copy link
Collaborator

rtxm commented Apr 21, 2020

I will merge as soon as you fixes the two little nits. Thank you.

@pablorodriper pablorodriper requested a review from rtxm April 21, 2020 17:17
@rtxm rtxm merged commit 4c24223 into allo-media:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants