Implement Spanish language #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtxm
reviewed
Apr 20, 2020
It's not very complicated, but we haven't got a unique suffix so it is like writing the cardinal number with other words. You can understand all the possibilities with the next picture: |
|
I see, better let them in full letters then! |
rtxm
reviewed
Apr 21, 2020
text_to_num/transforms.py
Outdated
| @@ -74,6 +74,8 @@ def alpha2digit( | |||
| if you prefer to get « moins 2 » instead of « -2 ». | |||
| """ | |||
| language = LANG[lang] | |||
| if lang is "es": | |||
There was a problem hiding this comment.
is raises a warning with literals; you should use == here.
|
I will merge as soon as you fixes the two little nits. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've implemented Spanish language support for your module.
It works from 0 to 999 999 999 999 like the other languages, but ord2card() is not implemented.
Hope it helps.