Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewrite rfp #64

Merged
merged 12 commits into from
Jul 18, 2023
Merged

chore: rewrite rfp #64

merged 12 commits into from
Jul 18, 2023

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 14, 2023 •
edited
Loading

  • Implement rfp-simple
  • Implement rfp-committee

Fixes #77
Fixes #78

@thelostone-mc thelostone-mc marked this pull request as ready for review July 14, 2023 14:59
zobront
zobront reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@zobront zobront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Left a few comments but otherwise looks ready to merge.

contracts/core/libraries/Payouts.sol Outdated Show resolved Hide resolved
contracts/strategies/RFPStrategy.sol Outdated Show resolved Hide resolved
contracts/strategies/RFPStrategy.sol Outdated Show resolved Hide resolved
contracts/strategies/RFPStrategy.sol Outdated Show resolved Hide resolved
codenamejason
codenamejason previously approved these changes Jul 14, 2023
View reviewed changes
@nfrgosselin nfrgosselin mentioned this pull request Jul 14, 2023
Closed
@thelostone-mc thelostone-mc changed the base branch from main to small-fixes July 17, 2023 10:34
Base automatically changed from small-fixes to main July 17, 2023 16:39
@nfrgosselin @thelostone-mc
update simple rfp spec (#67)
4b1b485 
* update simple rfp spec

* update language

* responding to comments

* chore: update structure

---------

Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
@nfrgosselin nfrgosselin linked an issue Jul 18, 2023 that may be closed by this pull request
Update simple rfp strategy #77
Closed
codenamejason
codenamejason previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@codenamejason codenamejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this reads a lot better. Nice job!

@0xKurt 0xKurt merged commit d3dbd11 into main Jul 18, 2023
1 check passed
@0xKurt 0xKurt deleted the rfp branch July 18, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xZakk 0xZakk 0xZakk left review comments

@zobront zobront zobront left review comments

@nfrgosselin nfrgosselin nfrgosselin left review comments

@0xKurt 0xKurt 0xKurt approved these changes

@codenamejason codenamejason codenamejason left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write RFP Committee strategy Update simple rfp strategy
6 participants
@thelostone-mc @0xZakk @zobront @codenamejason @nfrgosselin @0xKurt