-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade solidity 0.8.22 #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but curious if we it make sense to bump the version for others pragma solidity ^0.8.19;
to pragma solidity ^0.8.22;
Would there be side-effects cause of this ? @ilpepepig
My main concern was Other than that, the more compiler versions we support, the more likely integrators won't have issues integrating extensions and strategies with other third party contracts that might lock their contracts at a lower solidity version. I think I'd rather leave it at |
I think it's okey to keep it |
Closes DTT-289
About the decision to use ^0.8.19 instead of locking 0.8.22.
The good: don't force integrators to use 0.8.22
PUSH0
by now, which was introduced in 0.8.20 (Shanghai). However, in case someone wants to deploy on a chain which doesn't, allowing to use solidity 0.8.19 gives flexibility to easily do so.The bad