Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename selector_type to canonical_type to match solidity spec? #110

Closed
prestwich opened this issue Jun 13, 2023 · 2 comments
Closed

Rename selector_type to canonical_type to match solidity spec? #110

prestwich opened this issue Jun 13, 2023 · 2 comments

Comments

@prestwich
Copy link
Member 

          should we rename to `canonical_type` to match solidity spec?

Originally posted by @prestwich in #104 (comment)
@DaniPopes
Copy link
Member

"canonical" is only mentioned in the json docs and nowhere else (afaict), and it's not defined well. So I don't know, I think it's fine as it is now

@prestwich
Copy link
Member Author

Cool. Closing then 🌾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @DaniPopes