Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move blanket SolType for SolStruct impl to sol! macro #36

Closed
Tracked by #74
DaniPopes opened this issue May 15, 2023 · 1 comment · Fixed by #275
Closed
Tracked by #74

Move blanket SolType for SolStruct impl to sol! macro #36

DaniPopes opened this issue May 15, 2023 · 1 comment · Fixed by #275
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Member

This code:

https://github.com/ethers-rs/core/blob/23962043923bd859881e1c0021822641763e1564/crates/abi/src/types/struct.rs#L108-L112
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels May 15, 2023
@prestwich
Copy link
Member

prestwich commented Jun 20, 2023 •
edited
Loading

what do we gain by moving this? nvm it's blocking #90

@prestwich prestwich mentioned this issue Jun 20, 2023
Closed
@prestwich prestwich mentioned this issue Jul 20, 2023
Merged
3 tasks
This was referenced Sep 19, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: do not implement SolType for SolStruct generically alloy-rs/core
2 participants
@prestwich @DaniPopes