Experiment with back- foreground colors

[alloy]

It is hard on the eyes with a white background in the file browser if you have a dark color scheme.

Option 1: Use the same as the text view

Cons:

• the icons may blend in with the background color
• I think (maybe) that the file browser should be visually distinct from the text view
• background/foreground colors that look good for the text view may look bad for the file browser (this is basically the same as the first point)

If you want to try it out then you can get the background/foreground colors from -[NSWindowController setDefaultColorsBackground:foreground:] and simply pass those on to the file browser. I'd like to try it out too if you write a patch.

Option 2: Provide two presets

One for a dark background and one for a light background.

[alloy]

A dirty patch that shows roughly what it would work like: https://gist.github.com/1030607

[alloy]

FYI I personally prefer the normal style, i.e. white background, even though I have a dark vim view background.

[b4winckler]

Thanks for the patch. My initial reaction is ... argh! It looks terrible. I think the "cons" pretty much all apply. Even having only white backgrounds with black text is better than this.

I'm not sure how the two presets would work either. What colors should be used for dark color schemes?

[alloy]

Hehehe, yeah I had the same reaction, hence I didn’t take the time to create a nice patch.

I could ask our designer to think about the color scheme for a dark scheme, but as of right now I’m unsure if there’s one good solution to this. Although I dislike making things too configurable, maybe we should do it in this case and see what the community comes up with?

[b4winckler]

I also dislike lots of configuration options. If there were to be an option to set the background then it really needs to be accessible from Vim script in order to be useful and I think this is overkill at this stage. I vote for just leaving things as they are for now.

[alloy]

Agreed.

[jordwalke]

I feel this feature would be valuable.