Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Nested groups in timeline #2300

Closed
roboslone opened this issue Nov 11, 2016 · 20 comments
Closed

Nested groups in timeline #2300

roboslone opened this issue Nov 11, 2016 · 20 comments
Assignees
@yotamberk
Milestone
Minor Release v4.18

Comments

@roboslone
Copy link

roboslone commented Nov 11, 2016 •
edited
Loading

Hi! I'd like to use nested groups in timeline, is there a way to do so?

If it's not possible right now, could it be a feature?
I don't know if implementing infinite depth is necessary, I would personally be happy with max depth of 2 (one child and one parent). Probably setting any parent group as item's group should not be possible.
@roboslone
Copy link
Author

To clarify, this is what I want to see:
1

@yotamberk
Copy link
Contributor

I like this! I need this feature too!
Are you working on this?

@roboslone
Copy link
Author

roboslone commented Nov 11, 2016 •
edited
Loading

Are you working on this?

Sorry, I'm afraid I can't contribute to source code, my JS skills are awful :( I could help with ideas/testing or something like that, though.

@yotamberk
Copy link
Contributor

I hope I can get to this feature soon... I have a lot on my plate right now... I'll do my best

@roboslone
Copy link
Author

@yotamberk, thank you so much!

@mojoaxel
Copy link
Member

@yotamberk There are already subgroups. I think I have seen a timeline were somebody achieved something like this with subgroups.

@yotamberk
Copy link
Contributor

I've done something like that in subgroups, but still missing the functionality asked for in this feature

@roboslone
Copy link
Author

@mojoaxel, I've missed subgroups in docs, I'll try that.
Do you think subgroups should be mentioned in "Groups" section in docs?

Also, as @yotamberk mentioned, subgroups don't completely solve this issue, since they aren't displayed as normal groups.

@gerardp
Copy link

gerardp commented Nov 29, 2016 •
edited
Loading

Please, make it collapsible, something like that:

img111

@yotamberk yotamberk self-assigned this Nov 29, 2016
@yotamberk
Copy link
Contributor

yotamberk commented Nov 29, 2016 •
edited
Loading

@gerardp How do you expect the closed parent group to act? what Items should be shown in the parent? the sum of the items? all of the items of its children?

@gerardp
Copy link

gerardp commented Nov 29, 2016

@yotamberk
In my opinion, children are subtasks of the father. If I close the father only has to show the father's timeline, something similar to the gantt attached.

896px-ganttchartanatomy svg

@yotamberk
Copy link
Contributor

So basically the parent should be the sum of all children but in merged items, agreed?

@gerardp
Copy link

gerardp commented Nov 29, 2016 •
edited
Loading

@yotamberk
Not necessarily, i can also imagine some case that does not:

img3

@yotamberk
Copy link
Contributor

But the parent still must be somehow limited to not be smaller than the last item end time. That's why I'm not sure what rules must apply on this parent group. Do we allow the children items to be movable anywhere? does the parent adjust? or are the children limited by the parent?

@gerardp
Copy link

gerardp commented Nov 29, 2016

@yotamberk
I would do it as simple as possible, without any limitation on the size of the father or the children. It does not matter that the children outnumber the father.
What is your opinion?

@yotamberk
Copy link
Contributor

I think for a start I'll make the parent group independent of its children. Any kind of logic will have to be done by the user. Give me a few days. I'm on it.

@gerardp
Copy link

gerardp commented Nov 29, 2016

Great! thank you @yotamberk !!

@yotamberk yotamberk mentioned this issue Dec 5, 2016
Merged
mojoaxel pushed a commit that referenced this issue Dec 29, 2016
@yotamberk @mojoaxel
feat: #2300 Added nested groups (#2416)
8ab1d18 
* Fix groupEditable
* Fix group drag in vertical direction bug
* Fix indentation
* Add initial nestedGroups property
* Fix redraw order
* Get nested groups hiding working
* Add order to nestedGroups
* Fix up example
* Add support for intially closed nested groups
* Add nested groups indentation
* Fix indents
* Add nested groups docs
* Fix example
* Revert indents
* Add classes to nested and nesting group labels and add nesting group css
* Use pure css for nested group icons
* Remove commented off lines and unnecessary btn
* Fix indents
* Add support to showNested:false in group
* Add semicolon
* Remove empty lines
@mojoaxel
Copy link
Member

fixed by @yotamberk with #2416

@mojoaxel mojoaxel added this to the Minor Release v4.18 milestone Dec 29, 2016
@roboslone
Copy link
Author

Thanks!

@gerardp
Copy link

gerardp commented Dec 30, 2016

Thanks !!

@roboslone roboslone mentioned this issue Jan 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yotamberk yotamberk

Labels
None yet
Projects
None yet
Milestone
Minor Release v4.18
Development

No branches or pull requests
4 participants
@gerardp @mojoaxel @roboslone @yotamberk