Added structure for default values

[wimrijnders]

This adds the initial defaults structure. It currently only does the simple fields; the rest require a bit more work.

Sorry, my mind is not clear enough to do the rest right now. Will add it bit by bit.

[mojoaxel]

Why not move dataColor also to the DEFAULTS object?

[wimrijnders]

These need special handling

style:

    if (options.style !== undefined) {
      var styleNumber = this._getStyleNumber(options.style);
      if (styleNumber !== -1) {
        this.style = styleNumber;
      }
    }

dataColor:

  if (options.dataColor) {
      if (typeof options.dataColor === 'string') {
        this.dataColor.fill = options.dataColor;
        this.dataColor.stroke = options.dataColor;
      }
      else {
        if (options.dataColor.fill) {
          this.dataColor.fill = options.dataColor.fill;
        }
        if (options.dataColor.stroke) {
          this.dataColor.stroke = options.dataColor.stroke;
        }
        if (options.dataColor.strokeWidth !== undefined) {
          this.dataColor.strokeWidth = options.dataColor.strokeWidth;
        }
      }
    }

I only did the simple copyable fields right now.
Bear with me; I know what needs to be done.

[wimrijnders]

If you wait a moment, I can get xCenter and yCenter into the defaults.

[mojoaxel]

What's with showLegend an style?

[wimrijnders]

showLegend is non-trivial:

  this.showLegend        =  (this.defaultShowLegend !== undefined) ? this.defaultShowLegend : isLegendGraphStyle;

[wimrijnders]

Here you go; these were easy enough to do.

[wimrijnders]

Look, I see the 'Changes requested' message; I hope you understand that the rest is a bit harder to do than simply copying over. I stated in the initial message that this change does the 'simple' fields only, and that the rest requires 'a bit more work'.

Let me put it this way: do you agree until now? If so, there are two options:

1. Accept this PR and let me add the rest of the defaults incrementally in separate PR's.
2. Leave this PR open and wait till the rest has been done.

Both are fine with me. I have a personal preference for incremental PR's, but keeping this one open works for me as well.

[wimrijnders]

I would appreciate a response to previous in due time.

Also, I have to say I am a bit miffed that you slapped a 'Changes requested' on this PR without actually requesting changes. I really don't want to have to guess your thoughts.

Could you please explicitly state what changes you request? Thanks.

[wimrijnders]

So. You approved without adding a single word of response.

Alexander, I will state this explicitly because it is bothering me: I consider this non-communication of yours very, very bad form. Please change this.

[mojoaxel]

I consider this non-communication of yours very, very bad form. Please change this.

I'm very sorry! I'll try to communicate more.
Let me just say, it was late yesterday and actually I just agreed with you: "Accept this PR and let me add the rest of the defaults incrementally in separate PR's". That is why I just approved it. I should have just added "comments" and not "request changes". My mistake.
No bad atmosphere intended! ☮️

[wimrijnders]

Thank you very much! I honestly appreciate this response. Time for emoticons:

👍 ☀️ 😸 🎵 🍻

[mojoaxel]

@wimrijnders By the way: You are welcomed in our new chat-room (that sounds sooo 90s): https://gitter.im/vis-js/Lobby

[wimrijnders]

Thank you, Unfortunately, the link is not working.

[mojoaxel]

Thank you, Unfortunately, the link is not working.

I fixed it