This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
edit edge: restore original controlNodes position when dragged into nothing #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dropletzz thanks for the contribution, this looks nice. can you provide an example of this improvement in action or point us to an existing example that demonstrates the new behavior? |
17 tasks
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing an edge, if it's dragged into something that is not a node, the position of the control nodes will not be immediately updated, ending up with something like this.
As far as I can tell, this PR should fix that.
PS: fiy, I am using vis at work in order to create some kind of a graph editor. This is why I would like to change the
ManipulationSystemin order to make it UI-indipendent, or at least to add the possibility for it to be UI-indipendent, so that it could be easily integrated with custom UI elements. Any help, suggestions or insights would be very welcome (:EDIT: found out it can already be made independent of the menu buttons, I'll just add some functionality to it