Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Add support for graphviz edge "dir" #4202

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bewing
Copy link

@bewing bewing commented Nov 28, 2018

If the "dir" attribute is present in the edge, disable both arrows,
and selectively re-enable them based on dir.

If the "dir" attribute is present in the edge, disable both arrows,
and selectively re-enable them based on dir.
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add documentation for this feature. I think somewhere near here: https://github.com/almende/vis/blob/develop/docs/network/edges.html#L193

@bewing
Copy link
Author

bewing commented Nov 29, 2018

It appears the only DOT-specific documentation is at https://github.com/almende/vis/blob/develop/docs/network/index.html#L1568 -- I did add some examples to https://github.com/almende/vis/blob/develop/examples/network/data/dotLanguage/dotEdgeStyles.html -- perhaps just add some explicit language there specifying the mapping from DOT dir to vis.js arrows?

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps just add some explicit language there specifying the mapping from DOT dir to vis.js arrows?

I didn't realize that this is a DOT format feature.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants