Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on deinit() #68 and parameters retention after deinit() #69

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Mar 24, 2024

Description

Fixes for #68:

  • AAudio disabled in favor of OpenSL for Android <= 29
  • added PlayerErrors.playerAlreadyInited exception from cpp
  • tests.dart updated to check sync/async init()-deinit()

Fix for parameters retention after deinit()

  • after calling deinit() and then init() again, some player parameters like the max active voice count, was persisting. player.cpp has been updated to prevent this.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak requested a review from filiph March 26, 2024 10:13
Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alnitak alnitak merged commit 693dc25 into main Mar 26, 2024
1 check passed
@alnitak alnitak deleted the max-voices-reset branch March 26, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants