Please pull typo fix #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when the user clicks on a link, she gets to the no.html.erb page which only links to a "wiki/new" action without the newly to be created page title.
If there's no configuration set irwi will create a new instance of the configuration every time it is queried. Instead save the instance the first time it's queried.
That's an ugly no DRY solution, however it'll serve as an ugly wart to rip out once rails2 is phased out.
The problem was that, from example from a test: WikiPage.new() would make a new instance with content => nil. When invoking WikiPageController -> show show.html.erb would call "@page.content( nil)", which would call "wiki_show_attachments( nil )", which would call "nil.gsub", which would bomb. I think the optimal solution would be to set the default for the content column to an empty string inside the migration, however I did not succeed in implementing that (MySQL doesn't seem to allow default values for "TEXT" type columns?). And instead of peppering all methods with "foo( arg || '')" I though setting it in before_save would be the second best solution.
* therefore drop mention of RoR 2.x problems from the README * note that irwi is a RoR 3 plugin
Conflicts: lib/irwi/extensions/models/wiki_page_version.rb
Fixes: alno#19 See the commit itself for explanations of the technical details.
Fixes: alno#11
It would trigger the following: NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2011-10-01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit: tpo@03ca986
fixes the following issue: #11
Also it'd be nice to pull the history fix from earnold. I have it merged in my tree and it works as advertised so far :-)
Thanks,
*t