Disabled AzureDevOpsVariableSetConfigStoreTest in a way where it stil… #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l shows up in tests runner Left instructions on how to re-enable once it's implemented.
|
this is removed altogether, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled AzureDevOpsVariableSetConfigStoreTest in a way where it still shows up in tests runner, just as Inconclusive.
Left instructions on how to re-enable once it's implemented.
As far as I can tell, xunit does not have a way to skip the entire class, and skipping just the overridden method does not prevent exceptions from being thrown when all tests are run on the object that is now not set up properly.
If there's a better way to do this, I'm all ears.
It may also be an option to just change how the tests are set up so that [Fact(Skip = "reason")] works and doesn't let the ensuing tests run on the AzureDevOpsVariableSetConfigStoreTest class.
There may also just be a dumb reason why #if DEBUG isn't working in Rider for me.
I promise I did some research on xunit and figuring out how to ignore things, but unfortunately, I don't know what I don't know, which is quite a lot. Hence why I'm trying to get into collaboration and learn.
Please let me know if there's something I can do better. Right now I figure small, granular pull requests are better since you can pick and choose what to keep/drop.