Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Comments #113

Merged
merged 4 commits into from
May 25, 2024
Merged

Add Support for Comments #113

merged 4 commits into from
May 25, 2024

Conversation

timnieder
Copy link
Contributor

@timnieder timnieder commented May 24, 2024 •
edited
Loading

Closes #112
And also #103 (not related to the comments, but the document.body access)

@alonrbar
Copy link
Owner

Hi,
First of all, thank you for your contribution :)
Had a quick look and overall looks good. Can you add tests to verify the new functionality? I'd try to review as soon as possible once those exists.

@timnieder
Copy link
Contributor Author

Thanks for the quick response!
I added unit tests for the comments.
Not sure if I should add a comment to a docx file for a integration test or where that would fit in.

@alonrbar
Copy link
Owner

Looks great 👌
I would add an integration test but I'll merge the PR and just add it myself now.
Thanks again!

@alonrbar alonrbar merged commit a56c37c into alonrbar:master May 25, 2024
1 check passed
@alonrbar
Copy link
Owner

This PR is now part of v3.2.1, published just now to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for comments
2 participants
@timnieder @alonrbar