This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
3D parallel integration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to merge #36 first and then rebase master to this branch before we can merge |
|
Need some rebase and enhancement |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor problems not addressed:
len(devices)==1sharding will silently faultneed some code to addressdonated_invarsfor a stage.3d parallel2d parallel, etc.., might want a more unified user experience in both interface and implementations -- need some further discussion on this parthow to share a local array in DistributedArray (e.g., an intermediate state generated at fwd stage that will be used in bwd)