Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpaka/math Overloaded float specialization #837

Merged
merged 5 commits into from
Sep 13, 2019

Conversation

jkrude
Copy link
Contributor

@jkrude jkrude commented Sep 11, 2019

Fixed all falsly copy-pasted "standard libary".
Regarding all, but the min and max functions:
Added a template specialization for floats, to explicitly use the float backends.

Edit: added dependency

@jkrude jkrude changed the title alpaka/math alpaka/math Overloaded float specialization Sep 11, 2019
@tdd11235813
Copy link
Contributor

only HIP complains:

/home/travis/build/ComputationalRadiationPhysics/alpaka/include/alpaka/math/pow/PowHipBuiltIn.hpp(76): error: identifier "PowCudaBuiltIn" is undefined

/home/travis/build/ComputationalRadiationPhysics/alpaka/include/alpaka/math/pow/PowHipBuiltIn.hpp(81): error: identifier "PowCudaBuiltIn" is undefined

probably just a typo: Cuda -> Hip

@BenjaminW3
Copy link
Member

In how far does this depend on #828?
I know that it would be good to add this together with the corresponding tests. However, the tests are not yet ready and there are no code changes that depend on the other PR so it would be ok for me to merge this before the tests.

@psychocoderHPC
Copy link
Member

For me it looks like more this PR is independent of #828 and #828 is testing the new functionality you provided here.

@jkrude
Copy link
Contributor Author

jkrude commented Sep 12, 2019

Totally correct. This PR is not directly depending on #828, but if #828 is finished the new functionality could fully be tested. So not only the compiler-errors are checked but the functionality too. That is why I thought it would make sense waiting for #828.

@tdd11235813
Copy link
Contributor

the math tester in #828 actually enables testing of the alpaka math functions already at compile-time. Before, not all math functions have been used by the tests and thus some bugs have been undetected. By the math tester @jkrude could find the bugs. Thus this relies on #828, so we can detect possible bugs introduced by this PR :)

@BenjaminW3 BenjaminW3 merged commit d7c807c into alpaka-group:develop Sep 13, 2019
@BenjaminW3
Copy link
Member

Lets finalize #828 so that this is properly tested!

@psychocoderHPC psychocoderHPC mentioned this pull request Jan 2, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants