Example heat-equation #978
Conversation
|
clang as a CUDA compier complains about: |
| } | ||
| std::cout << "Max error to the exact solution at t = tMax: " << maxError << "\n"; | ||
|
|
||
| return EXIT_SUCCESS; |
There was a problem hiding this comment.
Could we return EXIT_FAILURE if the error is to large. Not sure to large for this example is but we should set it based on a test run on different hardware.
There was a problem hiding this comment.
Agree, we should add a check and report whether the test passed or failed. I will find the appropriate tolerance for this check (this is not immediately obvious). Output of error itself was useful during the development, but not good for testing.
There was a problem hiding this comment.
@sbastrakov You can keep the output, I saw it also in many CUDA examples.
Never the less could you please provide the PR with a approximately error range checking.
|
Please also rebase against #979 |
|
@jkrude The curent issue is a heap buffer overflow. |
- applied code style guide
|
I will merge this PR as it is the error margin validation can be pushed as separate PR. |
Alpaka implementation of solving the heat-equation based on a CPU version from @sbastrakov.