Reduce code duplication in CUDA memcpy and memset implementations #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they are now using the same underlying CUDA API calls, they can reuse the implementation and add the final wait depending on the queue type.
BenjaminW3
force-pushed
the
topic-reduce-cuda-mem-op-code-duplication
branch
from
bb3a434
to
11ddb14
Compare
|
@BenjaminW3 Please set always the milestone. This will help to create the changelog or later use the PIConGPU tool to auto generate it. |
|
@psychocoderHPC Could you please approve the changes? The Mac build is flaky. |
|
Yes, I am still review it. |
|
The changeset looks huge but I only moved the code to common implementation base classes (they were already there for copy but not for set). |
psychocoderHPC
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they are now using the same underlying CUDA API calls, they can reuse
the implementation and add the final wait depending on the queue type.
Result: -270 lines of code