Choose the value for the -arch nvcc flag depending on CUDA version #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code has hardcoded 2.0, not supported since CUDA 9. Closes alpaka-group#162.
|
Note: the documentation and examples still have 2.0 hardcoded, while with this PR that would be 2.0 for CUDA < 9 and 3.0 for CUDA >= 9. After an offline discussion with @psychocoderHPC we decided to leave it as is for now. |
|
This is only a quick fix we will modernize the make instead of doing it half wired. (see #163) |
psychocoderHPC
approved these changes
Sep 25, 2019
ax3l
reviewed
Sep 25, 2019
| @@ -22,7 +22,12 @@ endif() | |||
| # CUDA | |||
| ############################################################################### | |||
| find_package(CUDA REQUIRED) | |||
| set(CUDA_NVCC_FLAGS "-arch=sm_20;-use_fast_math;") | |||
| if(CUDA_VERSION VERSION_LESS 9.0) | |||
There was a problem hiding this comment.
Please add a if(NOT DEFINED COMPUTE_CAPABILITY) around this block, so one can configure it externally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code has hardcoded 2.0, not supported since CUDA 9.
Closes #162.