Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nested files to main entity #53

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Added nested files to main entity #53

merged 1 commit into from
Jan 26, 2023

Conversation

GlassOfWhiskey
Copy link
Member

A best practice in building RO-Crate manifests is to list nested files and folders directly into the hasPart field of the main entity (./), rather than listing them only in the parent folder. With this commit, StreamFlow adheres to this best practice.

A best practice in building RO-Crate manifests is to list nested files
and folders directly into the `hasPart` field of the main entity (`./`),
rather than listing them only in the parent folder. With this commit,
StreamFlow adheres to this best practice.
@codecov-commenter
Copy link

Codecov Report

Base: 63.12% // Head: 63.11% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7d2a9aa) compared to base (562ffdf).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   63.12%   63.11%   -0.01%     
==========================================
  Files          73       73              
  Lines        8591     8595       +4     
  Branches     2035     2036       +1     
==========================================
+ Hits         5423     5425       +2     
- Misses       2813     2816       +3     
+ Partials      355      354       -1     
Impacted Files Coverage Δ
streamflow/provenance/run_crate.py 11.58% <0.00%> (-0.09%) ⬇️
streamflow/workflow/combinator.py 90.16% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GlassOfWhiskey GlassOfWhiskey merged commit c9ec9a4 into master Jan 26, 2023
@GlassOfWhiskey GlassOfWhiskey deleted the fix-provenance branch January 26, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants