Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added persistence of Command class structure #74

Merged
merged 21 commits into from
Feb 25, 2023

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Feb 16, 2023

In the database the command executed by a step is saved in the form of a string.
With this PR it is saved in the database with the entire Command class and classes that extend it, also saving any classes used in the attributes, for example CWLCommandToken

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 65.23% // Head: 65.61% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (ae03c06) compared to base (1ed3ed5).
Patch coverage: 89.84% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   65.23%   65.61%   +0.37%     
==========================================
  Files          73       73              
  Lines        8655     8782     +127     
  Branches     2052     2087      +35     
==========================================
+ Hits         5646     5762     +116     
- Misses       2649     2658       +9     
- Partials      360      362       +2     
Impacted Files Coverage Δ
streamflow/cwl/command.py 84.70% <89.38%> (+1.79%) ⬆️
streamflow/core/workflow.py 91.58% <92.30%> (+0.03%) ⬆️
streamflow/workflow/step.py 79.79% <100.00%> (+0.06%) ⬆️
streamflow/deployment/aiotarstream.py 37.82% <0.00%> (-0.13%) ⬇️
streamflow/deployment/connector/container.py 60.31% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GlassOfWhiskey
Copy link
Member

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit 802fd42 into alpha-unito:master Feb 25, 2023
@LanderOtto LanderOtto deleted the feat/persistence-cmd branch September 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants