Added support for nested connectors #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
nested-connectors
branch
4 times, most recently
from
10c05a7
to
d2453df
Compare
This commit adds support for nested Connector classes through the `ConnectorWrapper` interface. The `QueueManagerConnector` is now implemented as a connector wrapper, automatically creating an inner SSH connector to maintain compatibility with the (deprecated) previous version, which inherited from the `SSHConnector` class. A new `wraps` property in the `deployment` configuration allows to define connector wrappers for other connectors. A single connector can be wrapped from multiple connector wrappers, but each wrapper can wrap a single inner connector. The `deploy` and `undeploy` actions are not automatically propagated to the inner connector to avoid spurious creations and deletions of connectors when multiple wrappers wrap the same object. Instead, the correct order of deployment and undeployment actions is in charge of the `DeploymentManager` class.
GlassOfWhiskey
force-pushed
the
nested-connectors
branch
from
d2453df
to
a41ea01
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 65.70% 65.42% -0.28%
==========================================
Files 73 75 +2
Lines 8794 8908 +114
Branches 2102 2118 +16
==========================================
+ Hits 5778 5828 +50
- Misses 2648 2713 +65
+ Partials 368 367 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for nested Connector classes through the
ConnectorWrapperinterface. TheQueueManagerConnectoris now implemented as a connector wrapper, automatically creating an inner SSH connector to maintain compatibility with the (deprecated) previous version, which inherited from theSSHConnectorclass.A new
wrapsproperty in thedeploymentconfiguration allows to define connector wrappers for other connectors. A single connector can be wrapped from multiple connector wrappers, but each wrapper can wrap a single inner connector.The
deployandundeployactions are not automatically propagated to the inner connector to avoid spurious creations and deletions of connectors when multiple wrappers wrap the same object. Instead, the correct order of deployment and undeployment actions is in charge of theDeploymentManagerclass.