Temporary changes for Global Bar [DO NOT MERGE] #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blue bar in the Browse page breadcrumb partial is removed so that when the global bar is deployed there is not two blue bars on Browse pages. This is a temporary change and will be reverted when the global bar has been removed.
Yellow bar on COVID-19 landing page has been removed so that two bars don't appear on the page when the global banner is deployed. There is also a rule added for making sure there is not too much spacing between the breadcrumb links and the navbar on mobile. These changes are temporary and will be removed when the global bar has been removed.
patrickpatrickpatrick
force-pushed
the
temp-move-breadcrumb-blue-bar
branch
from
f182369
to
99a4330
Compare
patrickpatrickpatrick
changed the title
matthillco
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until the global banner has been deployed.
Relevant Trello Card
What
Remove the blue bar from the Browse page breadcrump partial. Change the COVID-19 yellow bar to be the same colour as the header (essentially removing it). Add negative top margin to COVID-19 header on mobile viewports to ensure correct
spacing between breadcrumb and navbar.
Why
We are going to deploy the global bar for a period of time to alert users about the upcoming Emergency Alerts. These pages were designed with hardcoded top borders which don't come from the public_layout template. When the global bar is
deployed, the public_layout template will render the blue bar above it. This resulted in there being two blue bars on pages that have a hardcoded top border. The presence of the global bar is determined by the static application and other
frontend applications can't detect when it is or is not present. In the future, we need to rethink how handle blue/yellow bars on full-width pages. For now though, we want to deploy the global bar as soon as possible so we can raise
awareness of the Emergency Alerts. These changes will be easily removed when the global bar is removed.
Visual Changes
Before
Without Global Bar
With Global Bar
After
Without Global Bar
With Global Bar
Follow these steps if you are doing a Rails upgrade.