Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete guides #1223

Merged
merged 3 commits into from
May 12, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ Lint/HandleExceptions:
Lint/UnusedBlockArgument:
Exclude:
- 'app/helpers/campaign_helper.rb'
- 'app/helpers/part_helper.rb'
- 'config/routes.rb'
- 'lib/artefact_retriever.rb'
- 'lib/tasks/test_javascript.rake'
Expand Down Expand Up @@ -148,7 +147,6 @@ Style/MutableConstant:
- 'app/helpers/campaign_helper.rb'
- 'app/models/search_parameters.rb'
- 'app/presenters/local_authority_presenter.rb'
- 'app/presenters/part_presenter.rb'
- 'app/presenters/publication_presenter.rb'
- 'app/presenters/search_results_presenter.rb'
- 'config/initializers/content_api_credentials.rb'
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ the GOV.UK single domain.

### Formats

* https://www.gov.uk/becoming-a-british-citizen (guide)
* https://www.gov.uk/settle-in-the-uk (simple smart answer)
* https://www.gov.uk/register-to-vote (transaction start page)

Expand Down
36 changes: 0 additions & 36 deletions app/controllers/guide_controller.rb

This file was deleted.

5 changes: 0 additions & 5 deletions app/helpers/application_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ def page_title(publication = nil)

def wrapper_class(publication = nil)
services = %W[transaction local_transaction completed_transaction place]
guides = %W[guide travel-advice]
html_classes = []

if publication
Expand All @@ -20,10 +19,6 @@ def wrapper_class(publication = nil)
if services.include? publication.format
html_classes << "service"
end

if guides.include? publication.format
html_classes << "guide"
end
end
end

Expand Down
30 changes: 0 additions & 30 deletions app/helpers/guide_part_path_helper.rb

This file was deleted.

90 changes: 0 additions & 90 deletions app/presenters/guide_presenter.rb

This file was deleted.

17 changes: 0 additions & 17 deletions app/presenters/part_presenter.rb

This file was deleted.

25 changes: 0 additions & 25 deletions app/views/guide/_navigation.html.erb

This file was deleted.

24 changes: 0 additions & 24 deletions app/views/guide/_pagination.html.erb

This file was deleted.

7 changes: 0 additions & 7 deletions app/views/guide/_pagination_headers.html.erb

This file was deleted.

17 changes: 0 additions & 17 deletions app/views/guide/show.html+print.erb

This file was deleted.

26 changes: 0 additions & 26 deletions app/views/guide/show.html.erb

This file was deleted.

11 changes: 0 additions & 11 deletions config/locales/cy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@ cy:
common:
last_updated: "Diweddarwyd diwethaf"
formats:
answer:
name: "Ateb cyflym"
guide:
name: "Canllaw"
part: "Rhan"
printer_friendly_page: "Tudalen hawdd ei hargraffu"
at_beginning_of_guide: "Rydych chi ar ddechrau’r canllaw hwn"
at_end_of_guide: "Rydych wedi cyrraedd diwedd y canllaw hwn"
navigate_to_previous_part: "Llywio i’r rhan flaenorol"
navigate_to_next_part: "Llywio i’r rhan nesaf"
notes: "Nodiadau"
transaction:
name: "Gwasanaeth"
start_now: "Dechrau nawr"
Expand Down
17 changes: 0 additions & 17 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@ en:
common:
last_updated: "Last updated"
formats:
answer:
name: "Quick answer"
guide:
name: "Guide"
part: "Part"
printer_friendly_page: "Print entire guide"
at_beginning_of_guide: "You are at the beginning of this guide"
at_end_of_guide: "You have reached the end of this guide"
navigate_to_previous_part: "Navigate to previous part"
navigate_to_next_part: "Navigate to next part"
notes: "Notes"
transaction:
name: "Service"
start_now: "Start now"
Expand All @@ -38,9 +27,3 @@ en:
local_authority_starts_with_the_no_service_url_no_authority_link_html: "We've matched this postcode to <span class='local-authority'>%{local_authority_name}</span>."
find_my_nearest:
valid_postcode_no_locations: "We couldn't find any results for this postcode."
travel_advice:
alert_status:
avoid_all_but_essential_travel_to_parts: The <abbr title="Foreign and Commonwealth Office">FCO</abbr> advise against all but essential travel to parts of the country.
avoid_all_travel_to_parts: The <abbr title="Foreign and Commonwealth Office">FCO</abbr> advise against all travel to parts of the country.
avoid_all_but_essential_travel_to_whole_country: The <abbr title="Foreign and Commonwealth Office">FCO</abbr> advise against all but essential travel to the whole country.
avoid_all_travel_to_whole_country: The <abbr title="Foreign and Commonwealth Office">FCO</abbr> advise against all travel to the whole country.
7 changes: 0 additions & 7 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,6 @@
get ":slug/:part", to: redirect('/%{slug}') # Support for simple smart answers that were once a format with parts
end


# Guide pages
constraints FormatRoutingConstraint.new('guide') do
get ":slug/print", to: "guide#show", variant: :print
get ":slug(/:part)", to: "guide#show", as: "guide"
end

# Transaction pages
constraints FormatRoutingConstraint.new('transaction') do
get ":slug", slug: %r{(jobsearch|chwilio-am-swydd)}, to: "transaction#jobsearch"
Expand Down
2 changes: 1 addition & 1 deletion lib/artefact_retriever.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def initialize(content_api, logger, statsd, supported_formats = nil)
self.content_api = content_api
self.logger = logger
self.statsd = statsd
self.supported_formats = supported_formats || %w{completed_transaction guide licence
self.supported_formats = supported_formats || %w{completed_transaction licence
local_transaction place simple_smart_answer transaction travel-advice}
end

Expand Down
Loading