Swap gem layout #2774
Merged
Swap gem layout #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
cab5e3d
to
2caf45b
Compare
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
2caf45b
to
9458eb7
Compare
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
9458eb7
to
ae8cb74
Compare
Updating frontend to use the gem_layout
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
ae8cb74
to
27cc40c
Compare
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
27cc40c
to
0fd597d
Compare
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
0fd597d
to
1274c00
Compare
Changing some templates to use the full-width layout. Change layout & dependancies - Remove redundant feedback element (appeared twice on page) - Example Page: /find-local-council Update to resolve visual differences for frontend swap, changes resolve a border that is around the lookup element Remove borders / padding from swap on: "/foreign-travel-advice" to maintain existing visuals.
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
1274c00
to
630c457
Compare
to include Design System class
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
630c457
to
fa4bb72
Compare
added 5 commits
May 31, 2021 17:10
+ add margin to replace spacing between lookup and feedback. eg: /find-local-council
Adjust grid to match Design System + slight margin adjustments to mimic current design
- Update "/settle-in-the-uk" flow to use Design System grid, - Remove redundant CSS - Adjust Design to maintain or align.
Redundant as gem_layout_full_width replaces this.
chris-gds
force-pushed
the
swap-gem-layout-reduced
branch
from
fa4bb72
to
c0046ef
Compare
owenatgov
reviewed
Jun 1, 2021
Update to remove redundant classes and tags
owenatgov
approved these changes
Jun 2, 2021
| @@ -69,7 +69,7 @@ class LicenceTest < ActionDispatch::IntegrationTest | |||
| end | |||
|
|
|||
| within "#content" do | |||
| within ".page-header" do | |||
There was a problem hiding this comment.
Always big ❤️ to removing test-only classes.
There was a problem hiding this comment.
Unofficially approved 👍 I reckon we should hold off on this until Ian's point on the heading is sorted out.
🙌🏼 Holding tight re the header visual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update
frontendapp to usegem_layouttemplate fromstatic.Why?
As part of on-going a11y work to align architecture & use Components to ensure consistency and future proof to allow a11y improvements to cascade across the site.
Visuals
Slight changes, some manual spacing adjustments have been made to mimic current design.
Selection of visuals:
Anything else?
Related PRs
Enhancement PR:
Remove duplicate
<headers>Resolve e2e PR
alphagov/govuk_publishing_components#2101
Adding additional URLs to README for ref.
#2793
Converting the layout to the gem version resulted in the lookup pattern not inheriting the relevant styling correctly. Upon inspection, this is due to elements from the gem like
fieldsetnot being utilised withinfrontendand therefore not using the shared classes - this has been manually adjusted.Example page:
http://www.gov.uk/find-electoral-things
Solution
This ties into the issue raised here:
alphagov/govuk_publishing_components#2096
Should the lookup pattern be it's own Component or use a common combination of Components (
fieldset, input, buttonetc) these discrepancies would reduce.