Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adjusting the shape of the tracking attribute so once slimmer merges
layout_footer
with thepublic_layout
it gets combined correctly.Why?
Failing e2e tests on this PR revealed an issue related duplicate:
data-track-category
on the same node. It appears as slimmer tries to merge the footer gem with the public layout gem it doesn't combine the two duplicate attributes correctly into one, resulting in a duplication and then an e2e error.Visual Changes
No visual changes.
Anything else?
Maintains tracking attribute when used as stand alone as to not impact other uses
Related file: within public_layout
Replicating the e2e issue locally to debug involved:
static
./startup.sh
RACK_ENV=development ./startup.sh --live
withinfrontend