Remove Universal Analytics #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Looks good.
I've found a few instances of gem-track-click in en.yml that should be removed.
Also this reference to the old scroll tracker?
|
Thanks @andysellick - I had |
andysellick
approved these changes
Jun 25, 2024
| @@ -1,4 +1,3 @@ | |||
| <div data-module="track-start-page-tabs"> | |||
| <% | |||
There was a problem hiding this comment.
Nitpick: now that the wrapping DIV is gone, should this whole file be un-indented?
There was a problem hiding this comment.
@andysellick Thanks, done - good spot
AshGDS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
frontendcodebase