Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /schemas publishing api endpoints #1275

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Jun 12, 2024

This adds support for the /schemas end points added to the Publishing API in this PR, including test helper methods and pact tests alphagov/publishing-api#2767

Trello card here https://trello.com/c/NfqTSzH1/304-add-functionality-to-gds-api-adapters-to-list-and-fetch-schemas

@Harriethw Harriethw force-pushed the add-schema-publishing-api-endpoints branch 3 times, most recently from f470947 to 18abbe2 Compare June 13, 2024 14:45
@Harriethw Harriethw changed the base branch from main to fix-rack-dependency June 14, 2024 14:19
@Harriethw Harriethw force-pushed the add-schema-publishing-api-endpoints branch 3 times, most recently from 768af01 to eee161a Compare June 14, 2024 15:33
@tahb tahb force-pushed the add-schema-publishing-api-endpoints branch from eee161a to cfd13d7 Compare June 17, 2024 15:26
Harriethw and others added 2 commits June 18, 2024 10:11
`/schemas` and `/schemas/{schema_name}` were added
to the Publishing API in this PR [1]

This adds methods to the publishing_api adapter

[1] alphagov/publishing-api#2767

Co-authored-by: Tom Hipkin <tomhipkin@gmail.com>
Co-authored-by: Harriet H-W <harriethw@gmail.com>
`/schemas` and `/schemas/{schema_name}` were added
to the Publishing API in this PR [1].

This adds helper methods to stub responses to these
end points.

[1] alphagov/publishing-api#2767
@Harriethw Harriethw changed the base branch from fix-rack-dependency to main June 18, 2024 09:13
@Harriethw Harriethw force-pushed the add-schema-publishing-api-endpoints branch from cfd13d7 to 99b77e0 Compare June 18, 2024 09:14
@Harriethw Harriethw marked this pull request as ready for review June 18, 2024 09:17
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Harriethw Harriethw merged commit a834848 into main Jun 18, 2024
39 checks passed
@Harriethw Harriethw deleted the add-schema-publishing-api-endpoints branch June 18, 2024 10:55
pezholio added a commit that referenced this pull request Jun 24, 2024
* Add /schemas publishing api endpoints [PR](#1275).
* Add Pact tests for support-api [PR](#1273).
@pezholio pezholio mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants