This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably be a default in both here and our Vagrantfile, to speed up provisioning.
It has a bug in VMWare Fusion. |
😢 Not go in Vagrantfile then, or just in a virtualbox initializer until that gets fixed?
|
👍 |
Meh - this actually seems to break for me locally, so closing for now. |
For what value of break? |
When running
|
I'm kinda in favour of adding this. The number of people with VMWare is small (including me) and this massively speeds up provisioning with multiple VMs and multiple times for everyone using Virtualbox. I'm sure we could just wrap it in an if condition that excludes vmware users. |
I wasn't protesting it being merged, I was just flagging that it's broken in VMWare Fusion. Those using VMWare Fusion at the moment are on the bleeding edge so they can sort themselves out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be a default in both here and our Vagrantfile, to
speed up provisioning.