Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suggested_ordered_related_items #3005

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Dec 7, 2023

  1. Remove suggested_ordered_related_items

    Now that the [related links recommender](https://github.com/alphagov/govuk-related-links-recommender)
    is no longer running, suggested_ordered_related_items will be growing
    increasingly stale.
    
    I'm not sure whether publishing-api is even clever enough to keep
    suggested_ordered_related_items links somewhat up to date (e.g. if one
    is withdrawn, unpublished, or if a slug is changed) - it doesn't look
    like it from [a cursory glance at the
    code](https://github.com/alphagov/publishing-api/blob/main/lib/expansion_rules.rb).
    
    Note that there are around 164,000 published editions with
    suggested_ordered_related_items and only around 2,500 published editions
    with ordered_related_items, so this will have the effect of removing the
    related links sidebar from the majority of pages on GOV.UK (around
    161,000 of them).
    richardTowers committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c38f329 View commit details
    Browse the repository at this point in the history