Fix missing headings and replace subpage breadcrumb with back link #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
a11y-page-missing-main-heading
branch
from
d8a5957
to
862089d
Compare
matthillco
force-pushed
the
a11y-page-missing-main-heading
branch
from
862089d
to
0e49a5e
Compare
matthillco
force-pushed
the
a11y-page-missing-main-heading
branch
from
0e49a5e
to
08e5dce
Compare
matthillco
force-pushed
the
a11y-page-missing-main-heading
branch
from
08e5dce
to
d9ff5f2
Compare
matthillco
force-pushed
the
a11y-page-missing-main-heading
branch
from
d9ff5f2
to
59282d5
Compare
matthillco
changed the title
CodeSonia
force-pushed
the
a11y-page-missing-main-heading
branch
from
59282d5
to
32236e0
Compare
CodeSonia
force-pushed
the
a11y-page-missing-main-heading
branch
from
32236e0
to
d1e6bf8
Compare
CodeSonia
changed the title
unoduetre
reviewed
Jun 13, 2024
app/views/content_items/manuals/_manual_section_layout.html.erb
Outdated
Show resolved
Hide resolved
app/views/content_items/manuals/_manual_updates_layout.html.erb
Outdated
Show resolved
Hide resolved
CodeSonia
force-pushed
the
a11y-page-missing-main-heading
branch
from
d1e6bf8
to
af4c0b2
Compare
* Replaced the landing-page breadcrumb with H2 * Replaced the sub-page breadcrumb with the back link component * Added a "Contents" H2 above the document list * Rewrote tests accordingly
CodeSonia
force-pushed
the
a11y-page-missing-main-heading
branch
from
af4c0b2
to
8128fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The main content of the page doesn’t have a heading. There is the H1 of the manual header and then no other heading until the footer. Other pages within manuals have a heading before the lead paragraph. Trello
Why
These pages currently fail on accessibility and need to be fixed according to the findings of the DAC audit.
How
Before/After: Missing Headings
Before After: Replace breadcrumb with back link (Section)
Before After: Replace breadcrumb with back link (Updates)
Follow these steps if you are doing a Rails upgrade.