Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the IDs for macro options links are unique #848

Closed
hannalaakso opened this issue Apr 4, 2019 · 1 comment
Closed

Ensure that the IDs for macro options links are unique #848

hannalaakso opened this issue Apr 4, 2019 · 1 comment
Assignees
@NickColley
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) ⚠️ high priority Used by the team when triaging

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Apr 4, 2019 •
edited
Loading

We currently generate the ids for the anchor links within component macro options tables from title in frontendmatter. There are some ones that are not unique which breaks the links as the same id is used multiple times on the page. See #836

We used to use the example parameter from the template to do this but now that we use the frontend matter titles we should think about either having some tests to ensure that these are unique, or consider whether we should go back to using the example parameter as combined with titleSuffix, or some combination thereof.
@hannalaakso hannalaakso mentioned this issue Apr 4, 2019
Closed
@hannalaakso hannalaakso added the awaiting triage Needs triaging by team label Apr 4, 2019
hannalaakso added a commit that referenced this issue Apr 5, 2019
@hannalaakso
Fix broken in-page anchor for header component
1f2cf34 
#836

The larger issue is reported here: #848
@hannalaakso hannalaakso mentioned this issue Apr 5, 2019
Merged
@kellylee-gds kellylee-gds added Effort: days and removed awaiting triage Needs triaging by team labels Apr 10, 2019
@hannalaakso hannalaakso changed the title Ensure that the ids for macro options links are unique Ensure that the IDs for macro options links are unique Apr 10, 2019
@kellylee-gds kellylee-gds added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) ⚠️ high priority Used by the team when triaging labels Apr 10, 2019
@NickColley NickColley mentioned this issue Oct 7, 2019
Closed
@NickColley NickColley self-assigned this Oct 7, 2019
@NickColley
Copy link
Contributor

I think this is actually fixed, the ids are now unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickColley NickColley

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) ⚠️ high priority Used by the team when triaging
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickColley @hannalaakso @kellylee-gds