Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set navigation and mobile menu labels of the header component with new options #1905

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Set navigation and mobile menu labels of the header component with new options #1905

merged 2 commits into from
Aug 13, 2020

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Aug 11, 2020 •
edited
Loading

This PR:

  • adds macro options for localising the menu button and navigation label of the header
  • makes the previously hardcoded content the default text
  • adds tests to check for default and customised content

Fixes #1682

Have split localising the 'menu' text into #1904 following a chat with @christopherthomasdesign.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1905 August 11, 2020 17:19 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1905 August 11, 2020 17:20 Inactive
36degrees
36degrees approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1905 August 13, 2020 13:19 Inactive
@hannalaakso
Allow hardcoded text in header to be customised
4572d62 
Add new options:
- navigationLabel
- menuButtonLabel

Make the previously hardcoded content the default.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1905 August 13, 2020 13:23 Inactive
@hannalaakso hannalaakso merged commit e519d01 into master Aug 13, 2020
@hannalaakso hannalaakso deleted the header-localisation branch August 13, 2020 13:30
@hannalaakso hannalaakso mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

@vanitabarrett vanitabarrett vanitabarrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header navigation text cannot be customised or translated
4 participants
@hannalaakso @36degrees @vanitabarrett @govuk-design-system-ci