-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike to understand which colours would need adjusting to have a well designed dark mode #4903
Comments
@christopherthomasdesign is it accurate to say you're working on this one? |
Yes it is! Hoping to push something and write a summary on Monday 👍 |
Sorry for the delay! I’ve thrown a quick experiment onto a branch at https://github.com/alphagov/govuk-frontend/tree/darkmode-palette. It largely uses the palette developed by the planet-centred design working group at GDS. I've made some tweaks to improve colour contrast, but I haven't tested every colour combination at this point. You can probs just use the diff in that branch to see what I've changed, but here are a few thoughts I jotted down as I was going through:
|
This would align with my understanding for how dark modes should typically work. Dark mode shouldn't work like an inversion of light mode, but just as a darkening. If in light themes Thing A is darker than Thing B, or if Thing C becomes darker when focused, the same should be true when dark. |
Forgot to tidy issues at the end of the cycle, so closing this now 😊 |
What
Create stylesheet overriding our styles as bluntly as necessary to define which colours would need changing to implement dark mode, form a design point of view.
Particular attention might be necessary around links and focus styles.
Why
This will let us indentify the scope of the colours needing to be adjusted to support a dark mode.
Who needs to work on this
Designers, potentially with support from developers and accessibility specialist
Who needs to review this
Designers
Done when
The text was updated successfully, but these errors were encountered: